search

lsellens / script.service.audo

Audo (Automatic Downloader) is a fork of SABnzbd-Suite. SABnzbd-Suite Metapackage which combines SABnzbd, SickBeard, Couchpotato and Headphones in one Addon.
http://lsellens.openelec.tv/addons/repo/repository.lsellens/repository.lsellens.zip
GNU General Public License v3.0
10 stars 3 forks source link

Removed modifications to PYTHONPATH when not needed. #23

Closed romkal closed 7 years ago

romkal commented 7 years ago

For some reason both CouchPotato and SickBeard were segfaulting when this env variable was set on CuBox v4Pro. On the other hand SabNZBd requires this variable to be set.

I was not able to verify if this works correctly on other devices, but it fixed my Audo on OpenELEC 6 and 7.

I believe this fixes the problem mentioned in this forum thread: http://openelec.tv/forum/80-sabnzbd-suite/77928-couchpotato-not-starting

I was able to observe the segfault only when I started SickRage via commandline with the full environment copied from the script. Otherwise audo thinks it started correctly because it starts in the daemon mode.

Maybe it should be verified if the same change should be made to other programs (like NZBGet, ...)

lsellens commented 7 years ago

Can you test if SSL is working in couchpotato after this change? I'm not going to be home for a few days.

romkal commented 7 years ago

Unfortunately:

2017-01-03 15:15:20 MAIN :: pyopenssl module missing, please install for https access

For me it is still better than not starting at all...

I can try to identify the offending library that causes the crash though.

Maybe if we update it to some other version, things might work again with all those libraries.

On Tue, Jan 3, 2017, 13:19 lsellens notifications@github.com wrote:

Can you test if SSL is working in couchpotato after this change? I'm not going to be home for a few days.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/lsellens/script.service.audo/pull/23#issuecomment-270227552, or mute the thread https://github.com/notifications/unsubscribe-auth/AAdOxt3LmabaWS1309BlJw_QFpAW3pLDks5rOrtCgaJpZM4LY57R .

romkal commented 7 years ago

So the offending library is lxml.

Maybe instead of doing what I did in this pull request it would be enough, to get a new version of the library/

lsellens commented 7 years ago

lxml is just for faster scraping in couchpotato. Its not 100% necessary. It does work fine with x86_64. What error are you getting with the cubox? I think cubox uses armv7l is this correct?

romkal commented 7 years ago

Yes. CuBox uses armv7l

There is nothing in logs when I run it through audo, It just silently dies.

But when I run it in commandline setting all environement in the same way I get:

python

/storage/.kodi/addons/script.module.audo-programs/resources/SickBeard/SickBeard.py --daemon --datadir /storage/.kodi/userdata/addon_data/script.service.audo/ --pidfile=/var/run/sickbeard.pid --config /storage/.kodi/userdata/addon_data/script.service.audo/sickbeard.ini Illegal instruction (core dumped)

When I renamed lxml directory in /storage/.kodi/addons/script.module.audo-dependencies/lib into something else, so it seems that the module is not there, it starts correctly.

I see that you use lxml v. 3.4.2, while the newest is 3.7.1. Maybe upgrade would fix the problem? I just have no idea how to crosscompile lxml for armv7l to test it, and I cannot find any version already compiled to try it out.

wt., 3 sty 2017 o 16:24 użytkownik lsellens notifications@github.com napisał:

lxml is just for faster scraping in couchpotato. Its not 100% necessary. It does work fine with x86_64. What error are you getting with the cubox? I think cubox uses armv7l is this correct?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/lsellens/script.service.audo/pull/23#issuecomment-270263940, or mute the thread https://github.com/notifications/unsubscribe-auth/AAdOxhg1_IIxMINwV-vXrmOwQPdVwKQhks5rOubDgaJpZM4LY57R .

lsellens commented 7 years ago

Strange this would effect sickrage as it does not use lxml as far as I know

romkal commented 7 years ago

This is core dump. Who knows where and how it actually happens. Unfortunately it might be hard to properly pinpoint it, as openelec doesn't have a lot of development tools for this kind of work.. (at least I think it doesn't - I've never tried it).

The only thing that I thought about is to change the lxml to some other version and maybe it magically fixes the problem..

On Tue, Jan 3, 2017, 19:36 lsellens notifications@github.com wrote:

Strange this would effect sickrage as it does not use lxml as far as I know

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/lsellens/script.service.audo/pull/23#issuecomment-270288023, or mute the thread https://github.com/notifications/unsubscribe-auth/AAdOxsMjo2bQjVNJWptw_8R-HJucUy6Yks5rOxOlgaJpZM4LY57R .

lsellens commented 7 years ago

You can just remove lxml. It's a optional dependency. I'm guessing I just made a bad binary for armv7l. I don't own any hardware to test it on. Try putting everything back to stock and remove all of the lxml files. I'm wondering if it will still crash or if the problem is not limited to lxml after all. I'm running into issues cross compiling the newer version of lxml. Going to look at it again when I'm not sleepy.

lsellens commented 7 years ago

Couldn't sleep. Try this http://lsellens.openelec.tv/addons/devrepo/script.module.audo-dependencies/script.module.audo-dependencies-0.1.2~beta1.zip it has lxml 3.7.1 let me know if this makes a difference.

romkal commented 7 years ago

Crash again.

Core was generated by `python /storage/.kodi/addons/script.module.audo-programs/resources/SickBeard/Si'. Program terminated with signal SIGILL, Illegal instruction.

0 0x72aabe90 in ?? ()

from /storage/.kodi/addons/script.module.audo-dependencies/lib/lxml/etree.so (gdb)

On Tue, Jan 3, 2017, 22:43 lsellens notifications@github.com wrote:

Couldn't sleep. Try this http://lsellens.openelec.tv/addons/devrepo/script.module.audo-dependencies/script.module.audo-dependencies-0.1.2~beta1.zip it has lxml 3.7.1 let me know if this makes a difference.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/lsellens/script.service.audo/pull/23#issuecomment-270304898, or mute the thread https://github.com/notifications/unsubscribe-auth/AAdOxtE0HZBpOnfXmMntGLkpQzNVjqr-ks5rOz-SgaJpZM4LY57R .

lsellens commented 7 years ago

Looking at sickrage's code it does use lxml if available but falls back to beautifulsoup if unavailable. There must be something wrong with the lxml armv7l binary I cross compiled. Let see if I can track down what went wrong. Is this error still crashing couchpotato as well, or is this now just limited to sickrage?

lsellens commented 7 years ago

Does the cubox use imx6 builds?

romkal commented 7 years ago

Yes.

My installation in particular uses this build:

http://openelec.tv/forum/143-installation/82923-cubox-i4-pro-and-openelec-7-0-0-image-not-working#167339

because there were some problems with OpenELEC 7.0.0 kernel-panicking with CuBox i4 Pro.

czw., 5 sty 2017 o 11:01 użytkownik lsellens notifications@github.com napisał:

Does the cubox use imx6 builds?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/lsellens/script.service.audo/pull/23#issuecomment-270727801, or mute the thread https://github.com/notifications/unsubscribe-auth/AAdOxt_O-NzWMwvEm_lq2FRl4yu4N8Ivks5rPT3zgaJpZM4LY57R .

lsellens commented 7 years ago

Try this http://lsellens.openelec.tv/addons/devrepo/script.module.audo-dependencies/script.module.audo-dependencies-0.1.2~beta2.zip probably need a reboot after install

romkal commented 7 years ago

This build works perfectly well! No errors!

czw., 5 sty 2017 o 12:36 użytkownik lsellens notifications@github.com napisał:

Try this

http://lsellens.openelec.tv/addons/devrepo/script.module.audo-dependencies/script.module.audo-dependencies-0.1.2~beta2.zip probably need a reboot after install

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/lsellens/script.service.audo/pull/23#issuecomment-270750446, or mute the thread https://github.com/notifications/unsubscribe-auth/AAdOxow5I0lo5xW9FWZT9YYBCtQ-kNNrks5rPVRVgaJpZM4LY57R .

lsellens commented 7 years ago

Do me a favor. I might need you to test additional builds. In looking into this I ended up making a ton more changes that were not included in the build above. Most have to do with ssl. I'm having trouble trying to cross compile python-cryptography for arm. When I get that worked out I don't have a cubox to test myself, so keep an eye here for me to post more later. Thanks!

romkal commented 7 years ago

No problem. If you do me a build, I can try it.

On Thu, Jan 5, 2017, 21:24 lsellens notifications@github.com wrote:

Do me a favor. I might need you to test additional builds. In looking into this I ended up making a ton more changes that were not included in the build above. Most have to do with ssl. I'm having trouble trying to cross compile python-cryptography for arm. When I get that worked out I don't have a cubox to test myself, so keep an eye here for me to post more later. Thanks!

— You are receiving this because you modified the open/close state.

Reply to this email directly, view it on GitHub https://github.com/lsellens/script.service.audo/pull/23#issuecomment-270834185, or mute the thread https://github.com/notifications/unsubscribe-auth/AAdOxlCc4ewmfq35T30anwrg0iLc2zYoks5rPdAfgaJpZM4LY57R .