search

lserman / capistrano-elbas

Deploy Rails apps to AWS AutoScale groups
MIT License
96 stars 67 forks source link

Allow launch configuration customizations. #11

Closed eman8519 closed 8 years ago

eman8519 commented 8 years ago

This PR allows for more control over the launch configuration that is created once the new code has been deployed.

lserman commented 8 years ago

Thank you. This looks good and I will merge, but I wonder if we shouldn't just have one variable for the launch configuration that is a hash and plugs into the AWS API call directly. There is no sense trying to keep up with the AWS API or the needs of developers, we should just give them total control. I will include this in the aws-sdk v2 release.

eman8519 commented 8 years ago

That is a good point. I considered this myself, but decided that some developers (like myself) using this may not be fully aware of all of the options AWS provides for launch configs via the sdk. I guess documentation would help with that aspect, but sorta did this in a hurry.

Thank you very much for this gem it helps me a lot when deployed to my infrastructure. Let me know if I can ever lend a hand.

Thanks, -Randy

On Wednesday, March 2, 2016, Logan Serman notifications@github.com wrote:

Thank you. This looks good and I will merge, but I wonder if we shouldn't just have one variable for the launch configuration that is a hash and plugs into the AWS API call directly. There is no sense trying to keep up with the AWS API or the needs of developers, we should just give them total control. I will include this in the aws-sdk v2 release.

— Reply to this email directly or view it on GitHub https://github.com/lserman/capistrano-elbas/pull/11#issuecomment-191442198 .