search

lserman / capistrano-elbas

Deploy Rails apps to AWS AutoScale groups
MIT License
96 stars 67 forks source link

Ensures that instances across all reservations are returned #32

Closed kragej closed 5 years ago

kragej commented 5 years ago

Fixes #31

lserman commented 5 years ago

Realized I just posted this comment on the issue instead of the PR, moving it here sorry for e-mail spam :)

Thanks for this, can you add a spec for multiple reservations as well? It should be pretty easy to add in spec/aws/instance_collection_spec.rb. You can just make a new DescribeInstances_MultipleReservations stub in spec/support/stubs just like the existing DescribeInstances one.

kragej commented 5 years ago

Sure, I'll add a spec as soon as I can.

On Wed, 27 Feb 2019 at 18:19, Logan Serman notifications@github.com wrote:

Realized I just posted this comment on the issue instead of the PR, moving it here sorry for e-mail spam :)

Thanks for this, can you add a spec for multiple reservations as well? It should be pretty easy to add in spec/aws/instance_collection_spec.rb. You can just make a new DescribeInstances_MultipleReservations stub in spec/support/stubs just like the existing DescribeInstances one.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/lserman/capistrano-elbas/pull/32#issuecomment-467951255, or mute the thread https://github.com/notifications/unsubscribe-auth/AB-ZGQPmt-sRso_NaRjacarBQF7OrNsIks5vRr4sgaJpZM4bU72H .