Update default version of launch template

lserman / capistrano-elbas

Deploy Rails apps to AWS AutoScale groups

MIT License

96 stars 67 forks source link

Update default version of launch template #47

Open madmatvey opened 3 years ago

madmatvey commented 3 years ago

create_launch_template_version doesn't update default version of launch template. But at logger info we can see:

[ELBAS] Updating launch template with the new AMI...
[ELBAS] Updated launch template, new default version = 14

It is not true. I've added this PR to fix it :)

lserman commented 3 years ago

Hey, I'll look into getting these merged. Haven't maintained this repo in awhile. Think you could add a test here? Looks like there is a test for this but it must be wrong. Thanks!

madmatvey commented 3 years ago

Hey, I'll look into getting these merged. Haven't maintained this repo in awhile. Think you could add a test here? Looks like there is a test for this but it must be wrong. Thanks!

Give me a few moments, just start my production tests :) and already have some corrections.

madmatvey commented 3 years ago

@lserman tests done. May be this repo needs to setup a CircleCI? It may be more informative when tests was falling red with GH integrations.

duleorlovic commented 3 years ago

@lserman can you merge this ? I also tested on my aws machines and default version gets updated