search

lserman / capistrano-elbas

Deploy Rails apps to AWS AutoScale groups
MIT License
96 stars 67 forks source link

adapted elbas gem to handle private-IP-hostnames #50

Open afquinn opened 1 year ago

afquinn commented 1 year ago

Adapted the instance collection to take the hostnames of both public OR private Hostnames

lserman commented 1 year ago

Hello, wow, this is a blast from the past!

I don't know much about how AWS deployments are working these days. What is the use case for private IP and will this change affect existing users in any way? Perhaps there are users who have instances without public IPs that are currently being ignored by this gem. If they have private IPs though, wouldn't this change how the gem functions for them?

Maybe the inclusion of private IPs can be a configuration option, or maybe the list of instances can be completely overridable by a configuration lambda that receives the instance list and returns which ones should be included.