lserman / capistrano-elbas

Deploy Rails apps to AWS AutoScale groups
MIT License
96 stars 67 forks source link

Explicitly specify aws-sdk version 1 in gemspec and in require #8

Closed Satyricon closed 8 years ago

Satyricon commented 8 years ago

if you use aws-sdk version 2 in your own application bundler complains about version incompatibility

Bundler could not find compatible versions for gem "aws-sdk": In Gemfile: elbas (~> 0.19.0) ruby depends on aws-sdk (~> 1) ruby

aws-sdk (~> 2.1.19) ruby

So we can explicitly specify aws-sdk version 1in gemspec and elbas.rb file's require call

lserman commented 8 years ago

Thanks for this.

I am working on a refactor + aws-sdk v2 support also and will release that soon (:tm:) as well

Satyricon commented 8 years ago

Thanks for fast merge. One issue I'm currently having is that in original Launch Configuration I had IAM role specified and for new Launch config that role was not copied over. So for instances in Auto Scaling group IAM role was defining access to S# resources which after deployment I loose because IAM roles are not copied to new Launch Config. Will you be able to add some config param to Capistrano deploy.rb to specify IAM roles to use, or just copy over from old Launch config everything?

Thanks