lsh123 / xmlsec

XML Security Library
Other
132 stars 100 forks source link

Does not build against libxml 2.12.0 #728

Closed TimB87 closed 10 months ago

TimB87 commented 10 months ago

Hi there,

I am trying to compile xmlsec with libxml 2.12.0 installed, it seems like a few types have been changed:

In file included from app.c:29:                                                                                                                                                             
../include/xmlsec/xmlsec.h:100:80: error: unknown type name 'xmlExternalEntityLoader'                                                                                                       
  100 | XMLSEC_EXPORT void                              xmlSecSetExternalEntityLoader (xmlExternalEntityLoader entityLoader);                                                               
      |                                                                                ^~~~~~~~~~~~~~~~~~~~~~~                                                                              
In file included from enveloped.c:25:                                                                                                                                                       
../include/xmlsec/xmlsec.h:100:80: error: unknown type name 'xmlExternalEntityLoader'                                                                                                       
  100 | XMLSEC_EXPORT void                              xmlSecSetExternalEntityLoader (xmlExternalEntityLoader entityLoader);                                                               
      |                                                                                ^~~~~~~~~~~~~~~~~~~~~~~                                                                              
In file included from buffer.c:25:                                                                                                                                                          
../include/xmlsec/xmlsec.h:100:80: error: unknown type name 'xmlExternalEntityLoader'                                                                                                       
  100 | XMLSEC_EXPORT void                              xmlSecSetExternalEntityLoader (xmlExternalEntityLoader entityLoader);                                                               
      |                                                                                ^~~~~~~~~~~~~~~~~~~~~~~                                                                              
In file included from bn.c:26:                                                                                                                                                              
../include/xmlsec/xmlsec.h:100:80: error: unknown type name 'xmlExternalEntityLoader'                                                                                                       
  100 | XMLSEC_EXPORT void                              xmlSecSetExternalEntityLoader (xmlExternalEntityLoader entityLoader);                                                               
      |                                                                                ^~~~~~~~~~~~~~~~~~~~~~~                                                                              
make[3]: *** [Makefile:720: enveloped.lo] Error 1                                                                                                                                           
make[3]: *** Waiting for unfinished jobs....                                                                                                                                                
make[3]: *** [Makefile:720: app.lo] Error 1

Building libxml2 with --with-legacy does not provide stubs to successfully compile xmlsec.

lsh123 commented 10 months ago

From 2.12.0 release notes:

Several cyclic dependencies in public header files were fixed. As a result, certain headers won't include other headers as before.

The PR #729 should address this.

TimB87 commented 10 months ago

@lsh123 seems to work fine for me, thank you!

lsh123 commented 10 months ago

Thanks for confirmation!