search

lsharir / angular-d3-graph-example

[Example Project] Angular 2 with D3 interactive graph
https://lsharir.github.io/angular-d3-graph-example/
179 stars 122 forks source link

updates for Angular8 #13

Open 404Assassin opened 5 years ago

404Assassin commented 5 years ago

Rather then try and go through the Angular update process, across so many major versions, I started a new Angular8 project created with the cli and copied your code into it Class by Class. Applied fixes to recent TypeScript and Angular8 changes like directive attributes. Also changed some minor stuff to reflect recent Angular best practices, like direct imports instead of barrel indexes etc. Fixed some items that TSLint and IntelliJ were complaining about (like selectors). It's essentially your code in a new ng8 project.

lsharir commented 5 years ago

Thanks! I'll go over it during the weekend. Is there an easy way to remove the tests files \ packages? I originally built it without tests as to not confuse new developers with unnecessary code

dhruv217 commented 5 years ago

I would suggest leaving the test in there, for reminding the uninitiated of having less on an anxiety attack before deploying to production.

Mech0z commented 4 years ago

Any updates to this?

404Assassin commented 4 years ago

You're welcome to check my version out here: https://github.com/404Assassin/angular-d3-graph-example/tree/ng8 It still includes the test files and I haven't had the time to either wirer them up correctly or remove them. I would like to wirer them up at some point so that they are returning something meaningful, just haven't had the time.