Weekly release 2020_03_10 - Githubissues

lshtm-gis / WHO_PHSM_Cleaning

Cleaning PHSM provider data for WHO

https://lshtm-gis.github.io/WHO_PHSM_Cleaning/html/

MIT License

0 stars 1 forks source link

Weekly release 2020_03_10 #178

Closed hamishgibbs closed 3 years ago

hamishgibbs commented 3 years ago

A variety of changes required for cleaning this week.

New changes:

Trimmed whitespace in EURO data prov_XXXXX columns.
Addressed date issues reading dates with Hours & Minutes which introduced a bug merging OXCGRT records.
Updated a number of scripts to conform to flake8.
Added a random .R in src/manual as I chased bugs.

A few takeaways:

It would be helpful to program with a linter. I use Atom + flake8.
There is room to improve speed, portability & reliability of the routine and quite a few open issues in these areas.

I have opened a project and hope to introduce some of these changes this week but it will require additional work together as we go forward.