search

lsiddiquee / com.rexwel.bmwconnected

GNU General Public License v3.0
2 stars 3 forks source link

Support for Mini Connected in Homey? #22

Open Petter-Adberg opened 1 year ago

Petter-Adberg commented 1 year ago

Are there plans to also support the Mini Connected? As I understand it, the functionality between BMW Connected and Mini Connected is very similar?

HarryInia commented 6 months ago

I'm interested in the topic Mini Connected with Homey Pro 23 Any update or reply?

sschutten commented 5 months ago

Hi, I'm looking into this. I'm not the original maintainer of this app, but I have a Mini SE myself and would love to hook it up to Homey. So I decided to take on the task to enable it for this app. So far I've discovered that it's not necessarily a limitation of the app but rather the bmw-connected-drive package this app relies on. The package doesn't take Mini into account. The bimmerconnected project does, which is what the bmd-connected-drive package was based on. I'll have to fix that first before we can add it to this app.

HarryInia commented 5 months ago

Excellent; I appreciate you picking up this action!

On 15 Mar 2024, at 18:07, Sander Schutten @.***> wrote:

Hi, I'm looking into this. I'm not the original maintainer of this app, but I have a Mini SE myself and would love to hook it up to Homey. So I decided to take on the task to enable it for this app. So far I've discovered that it's not necessarily a limitation of the app but rather the bmw-connected-drive https://github.com/lsiddiquee/bmw-connected-drive package this app relies on. The package doesn't take Mini into account. The bimmerconnected https://github.com/bimmerconnected project does, which is what the bmd-connected-drive package was based on. I'll have to fix that first before we can add it to this app.

— Reply to this email directly, view it on GitHub https://github.com/lsiddiquee/com.rexwel.bmwconnected/issues/22#issuecomment-2000088487, or unsubscribe https://github.com/notifications/unsubscribe-auth/BGUJ7HCGDG7Y7BMM4N7SDXLYYMTFDAVCNFSM6AAAAAAQMM7X2WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMBQGA4DQNBYG4. You are receiving this because you commented.

sschutten commented 5 months ago

I'm making progress. I've just submitted a PR for supporting Mini in the bmw-connected-drive package: https://github.com/lsiddiquee/bmw-connected-drive/pull/19 Once this one is through I can update the Homey app to make use of it 😄

HarryInia commented 5 months ago

👍Verzonden vanaf mijn Galaxy -------- Oorspronkelijk bericht --------Van: Sander Schutten @.> Datum: 16-03-2024 15:26 (GMT+01:00) Aan: "lsiddiquee/com.rexwel.bmwconnected" @.> Cc: HarryInia @.>, Comment @.> Onderwerp: Re: [lsiddiquee/com.rexwel.bmwconnected] Support for Mini Connected in Homey? (Issue #22) I'm making progress. I've just submitted a PR for supporting Mini in the bmw-connected-drive package: lsiddiquee/bmw-connected-drive#19 Once this one is through I can update the Homey app to make use of it 😄

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you commented.Message ID: @.***>

PetterAdberg commented 5 months ago

@sschutten, nice to see you take on this old task that is still relevant. Good luck and get in touch if you need help with testing.

sschutten commented 3 months ago

I'm happy to share that I've been able to add support for Mini to the app and my changes are submitted for review by the original author of the app. In the meantime, if are not afraid of a bit of command line, you can get in touch with me and I can share a test version of the app for you to test.

HarryInia commented 1 month ago

Hi Sander, I was curious how it goes with “Mini connected”... Cheers Harry

On 1 Jun 2024, at 11:36, Sander Schutten @.***> wrote:

I'm happy to share that I've been able to add support for Mini to the app and my changes are submitted for review by the original author of the app. In the meantime, if are not afraid of a bit of command line, you can get in touch with me and I can share a test version of the app for you to test.

— Reply to this email directly, view it on GitHub https://github.com/lsiddiquee/com.rexwel.bmwconnected/issues/22#issuecomment-2143380879, or unsubscribe https://github.com/notifications/unsubscribe-auth/BGUJ7HEKID57ZLHM73HTYZTZFGIY5AVCNFSM6AAAAAAQMM7X2WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNBTGM4DAOBXHE. You are receiving this because you commented.

sschutten commented 1 month ago

Hi Harry, It is ready, but I'm awaiting the review of the original maintainer of the app. I hope he's able to get to it soon, but can't give any timelines so far.

HarryInia commented 1 month ago

Looking forward to it. Thx for your efforts.

On 2 Aug 2024, at 12:00, Sander Schutten @.***> wrote:

Hi Harry, It is ready, but I'm awaiting the review of the original maintainer of the app. I hope he's able to get to it soon, but can't give any timelines so far.

— Reply to this email directly, view it on GitHub https://github.com/lsiddiquee/com.rexwel.bmwconnected/issues/22#issuecomment-2265017677, or unsubscribe https://github.com/notifications/unsubscribe-auth/BGUJ7HAFKR6STRA2Z4FAQCDZPNKEXAVCNFSM6AAAAAAQMM7X2WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENRVGAYTONRXG4. You are receiving this because you commented.