[Android Codepath] Week 1 Assignment - Instagram Popular Client

[lsilbers]

My app is complete. Please review /cc @codepathreview @codepath

Also I am curious about what the appropriate way to clear an image view would be in my adapter I initially was doing setImageResource(0) and it was working fine but when I added the support for the Swipe To Refresh all of a sudden I started getting resource not found exceptions - but only for one of the image views! I found a work around by creating a placeholder image but I would like to know why this happened in only one of the two image views...

Edit: they are lines 56 and 66 respectively

[codepathreview]

Good job overall completing the required stories along with a few optionals. A few notes after checking out the code:

• Not sure why you got the resource not found exception, setImageResource(0) should work fine. But your approach of setting the placeholder image is the correct approach.
• Good layout, proper view naming, usage of sp/dp, margin and relative placement rules
• Consider externalizing string resources for internationalization, even if they're just hint texts. Consider using android:hint instead of android:text as appropriate.
• Nice effort at UI polishing and using CircleTransformation for rounding the images
• Consider better organizing your source files
• Good job using the ViewHolder pattern to improve performance of photos ListView.
• Consider including a check to see if internet is available to detect any network failures. Show an appropriate message in case of failure.
• Consider overriding onFailure method in JsonHttpResponseHandler to handle error messages appropriately.

One of the most important part of these projects is that you add additional features and tweak the UI / UX because that will provide many more learning opportunities. I would encourage you to complete the projects each week with required stories early and then spend time adding your own UI elements and experimenting with optional extensions that will improve the user experience.

We have provided a detailed Project 1 Feedback Guide here which covers the most common points we see for this project. Read through the feedback guide point-by-point to determine other ways you could improve your submission. You should consider going back and implementing applicable feedback as well. Keep in mind that one of the most important parts of Android development is learning the correct patterns and conventions.

Hopefully this first project has given you a better sense of working with RelativeLayout which is a very flexible layout system, probably one of the most powerful responsive-first layout systems available across web and mobile platforms. This assignment also gave us our first introduction to networking, working with APIs and loading remote images. The next assignment will introduce new concept such as accepting user input and navigating between activities but will also reinforce important concepts such as networking, using APIs, handling remote images.

If you have any particular questions about the assignment in general or on any of the feedback, feel free to reply here or or email us support@codepath.com.

P.S. Good to see you properly added the readme with features and screenshots to your project as described in the submitting assignments guide!