lsirivong / gatsby-plugin-modal-routing

A gatsby plugin for routable modals
44 stars 30 forks source link

Always `false` + different props than docs #59

Closed marcelscruz closed 1 year ago

marcelscruz commented 3 years ago

For some reason, I don't seem to be able to get it to work.

I'm currently using the same package version as the example project (1.1.0-beta), even though I tried other versions too, and even copying the exact code from the example, but it doesn't work.

In fact, the props I receive from the ModalRoutingContext.Consumer is different from the one detailed in the docs.

Screenshot 2021-03-11 at 15 43 29

I receive isModal instead of modal.

And isModal is always false.

Am I missing something here?

Any help is very appreciated. Thanks!

coreAux commented 3 years ago

Same here. Resolved it by following the steps in this thread.

TL;DR: If you're running Gatsby v.3 make sure to install gatsby-plugin-modal-routing-3 and replace all imports/configs.

andreisemianiuk commented 2 years ago

I have the same problem! How to fix it?

coreAux commented 2 years ago

I have the same problem! How to fix it?

@andreisemianiuk what version Gatsby are you using and what version plugin? Have you tried following the step in this thread?

andreisemianiuk commented 2 years ago

"gatsby": "^4.9.3", gatsby-plugin-modal-routing-3 I've tried this thread, but had the same problem. Actually I don't use it now

otkstudio commented 2 years ago

@marcelscruz Where you able to resolve this? The steps in the mentioned thread didn't solve my problem. I have the exact issue you had.

marcelscruz commented 2 years ago

@otkstdio not really, never found a fix and then moved to a different implementation.

otkstudio commented 2 years ago

@marcelscruz Would you mind sharing the implementation you went with? I'm getting tired of attempting to make this package work. It's become very frustrating.

marcelscruz commented 2 years ago

@otkstdio sorry, I meant I gave up what I was trying to do 😅