lsismeiro / awesome-ha-blueprints

A curated collection of automation blueprints for Home Assistant.
https://epmatt.github.io/awesome-ha-blueprints
GNU General Public License v3.0
78 stars 16 forks source link

Fixed E1743 dimming up/down regex #1

Closed elephantmetropolis closed 1 year ago

elephantmetropolis commented 1 year ago

Thank you for taking the time to work on a Pull Request. Your contribution is really appreciated! :tada: Please don't delete any part of the template, since keeping the provided structure will help maintainers to review your work more rapidly.

Sections marked as * are required and need to be filled in.

Proposed change*

This PR fixes a known regex problem involved in dimming up/down. Without the fix the value of the light brightness keep increasing/decreasing until light turn totally on/off. It also yields hundreds of events and add some lag to the lamp.

Checklist*

LewisSpring commented 1 year ago

Hi @elephantmetropolis Thanks for your pull request. Can you confirm that the blueprint works by adding the following URLS as blueprints?: raw.githubusercontent.com/lsismeiro/awesome-ha-blueprints/be6ba9333b14cdb1e296be0e3935b4af5e6976bb/blueprints/controllers/ikea_e1743/ikea_e1743.yaml raw.githubusercontent.com/lsismeiro/awesome-ha-blueprints/be6ba9333b14cdb1e296be0e3935b4af5e6976bb/blueprints/controllers/ikea_e1812/ikea_e1812.yaml

Other than that, looks good and should be able to merge these for you.

elephantmetropolis commented 1 year ago

Looks good to me !

LewisSpring commented 1 year ago

Great. Will merge for you Don't forget to update your blueprints (again, sorry!) to point to the repository :)

timcreatedit commented 11 months ago

Hey, thanks for the great work! For my E1743 buttons, the long press still doesn't work with this, what could I be doing wrong?

LewisSpring commented 11 months ago

Hi Tim

I don't have this remote so unfortunately can't test for you. Maybe @elephantmetropolis can provide some insight if possible, :)

Can you confirm whether the actions from the remote and the blueprint are matching?

@lsismeiro If possible could you enable issues, and I will turn this into one?

Cheers :)

lsismeiro commented 11 months ago

Hi @LewisSpring,

I think I managed to enable issues, please check.

Regards, Luis Sismeiro

On Sat, 25 Nov 2023 at 20:04, LewisSpring @.***> wrote:

Hi Tim

I don't have this remote so unfortunately can't test for you. Maybe @elephantmetropolis https://github.com/elephantmetropolis can provide some insight if possible, :)

Can you confirm whether the actions from the remote and the blueprint are matching?

@lsismeiro https://github.com/lsismeiro If possible could you enable issues, and I will turn this into one?

Cheers :)

— Reply to this email directly, view it on GitHub https://github.com/lsismeiro/awesome-ha-blueprints/pull/1#issuecomment-1826409893, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGFWMV5RM2PQWAHJQBAWKOTYGJFMTAVCNFSM6AAAAAA5TV2ENKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMRWGQYDSOBZGM . You are receiving this because you were mentioned.Message ID: @.***>