search

lskatz / fasten

:construction_worker: Fasten toolkit, for streaming operations on fastq files
MIT License
76 stars 6 forks source link

Consider std::io::Stdin instead of File('/dev/stdin') #22

Open bovee opened 12 months ago

bovee commented 12 months ago

I'm not sure if there's a performance difference (in which case please feel free to add a comment and disregard this), but I think opening /dev/stdin instead of using std::io::Stdin might limit the platforms fasten works on to only POSIX ones (i.e. probably not Windows). Not a high priority, but an easy search/change and probably a good beginner bug.

lskatz commented 11 months ago

Thank you for that tip! I am going to leave this ticket open for when I start refactoring.