lsmo-epfl / aiida-lsmo

AiiDA workflows for the LSMO laboratory at EPFL
Other
9 stars 13 forks source link

Add mc moves #109

Open mpougin opened 1 year ago

mpougin commented 1 year ago

For charged molecules Raspa outputs the warning: WARNING: REINSERTION MOVE USED ON CHARGED IONS (IF POSSIBLE, CHANGE TO RANDOM TRANSLATION MOVE TO AVOID NUMERICAL PROBLEMS)

Reinsertion probability 1.0 is still the default in the simannealing wc but I added the possibility to change this value and specify a random translation probability

mpougin commented 1 year ago

@kjappelbaum, you have an idea why the coverage report fails?

kjappelbaum commented 1 year ago

😮 that's a large PR 😆

kjappelbaum commented 1 year ago

probably it is a token issue for the coverage upload, I'll give it a look

mpougin commented 1 year ago

😮 that's a large PR 😆

It's mainly the mock-code files that changed. My modification slightly modifies the input of the test-calculation (it now adds by default randominsertionprobability 0.0, so I had to generate new mock code for the simannealing test. The code/example modifications are in the first commit

mpougin commented 1 year ago

probably it is a token issue for the coverage upload, I'll give it a look

Thank you :)

mpougin commented 1 year ago

probably it is a token issue for the coverage upload, I'll give it a look

maybe it's related to this? https://github.com/codecov/codecov-action/issues/557