lsmo-epfl / aiida-lsmo

AiiDA workflows for the LSMO laboratory at EPFL
Other
9 stars 13 forks source link

Adapt the cp2k parsers to the new aiida-cp2k package. #38

Closed yakutovicha closed 4 years ago

yakutovicha commented 4 years ago

This PR removes the copy-pasted BaseCp2kParser with the parser imported from the aiida-cp2k plugin. Due to the changes introduced recently in https://github.com/aiidateam/aiida-cp2k/pull/84, the multistage workflow woudn't work correctly with the latest version of the cp2k plugin.

yakutovicha commented 4 years ago

To be honest I've no idea why docs are not building. The aiida-cp2k package is installed, but there is sitll a complaint:

/home/runner/work/aiida-lsmo/aiida-lsmo/aiida_lsmo/parsers/__init__.py:docstring of aiida_lsmo.parsers.Cp2kAdvancedParser:1:py:class reference target not found: aiida_cp2k.parsers.Cp2kBaseParser
danieleongari commented 4 years ago

The documentation is not working on my computer too, after pulling your PR branch:

writing output... [100%] index                                                                                                                                                                                

Warning, treated as error:
/home/daniele/aiida1/aiida-lsmo/aiida_lsmo/parsers/__init__.py:docstring of aiida_lsmo.parsers.Cp2kAdvancedParser:1:py:class reference target not found: aiida_cp2k.parsers.Cp2kBaseParser
Makefile:27: recipe for target 'customdefault' failed
make: *** [customdefault] Error 2
danieleongari commented 4 years ago

I tested:

And they run fine: please merge after fixing the documentation.

ltalirz commented 4 years ago

I'm also not quite sure where exactly it comes from, but you can either add the missing reference to the nitpick exceptions: https://github.com/lsmo-epfl/aiida-lsmo/blob/develop/docs/source/conf.py#L73

or add aiida_cp2k to intersphinx https://github.com/lsmo-epfl/aiida-lsmo/blob/develop/docs/source/conf.py#L70

yakutovicha commented 4 years ago

or add aiida_cp2k to intersphinx https://github.com/lsmo-epfl/aiida-lsmo/blob/develop/docs/source/conf.py#L70

Thanks Leo, it worked!