lsmo-epfl / aiida-lsmo

AiiDA workflows for the LSMO laboratory at EPFL
Other
9 stars 13 forks source link

Add multicomp wc #45

Closed danieleongari closed 3 years ago

danieleongari commented 4 years ago

I'm adding a work chain built on @pzarabadip's MultiCompIsotherm wc.

It does, for a gas mixture:

The managing of the input parameters, especially for the molecules, need some rationalizations. The same for the output_parameters. I was considering building a work chain that is not limited to two GCMC calculation (ads, des), but can be extended to sample any number of conditions (here the name AdsorptionWC)... but constraining to only two (ads, des) is probably a clearer user case, allows for a simpler input/output/logic, especially when deciding to use the composition from the result of a prvious calculation.

codecov-io commented 3 years ago

Codecov Report

Merging #45 (0811b32) into develop (6c063cf) will decrease coverage by 4.07%. The diff coverage is 18.98%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #45      +/-   ##
===========================================
- Coverage    36.88%   32.81%   -4.08%     
===========================================
  Files           22       25       +3     
  Lines         1556     2008     +452     
===========================================
+ Hits           574      659      +85     
- Misses         982     1349     +367     
Impacted Files Coverage Δ
aiida_lsmo/workchains/multicomp_ads_des.py 16.47% <16.47%> (ø)
aiida_lsmo/workchains/multicomp_gcmc.py 16.99% <16.99%> (ø)
aiida_lsmo/workchains/singlecomp_widom.py 22.50% <22.50%> (ø)
aiida_lsmo/workchains/__init__.py 100.00% <100.00%> (ø)
aiida_lsmo/workchains/isotherm.py 89.94% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6c063cf...0811b32. Read the comment docs.

danieleongari commented 3 years ago

The PR is now ready for merging. The initial concept of one wc was split into 3 work chains:

The forcefields of some molecules were also added or fixed.