lsmo-epfl / aiida-lsmo

AiiDA workflows for the LSMO laboratory at EPFL
Other
9 stars 13 forks source link

Add oxidation state prediction #65

Closed ltalirz closed 3 years ago

ltalirz commented 3 years ago

@danieleongari can you suggest 1-2 interesting mofs to predict the oxidation state, to replace Fe-mof74 and Mg-mof74?

codecov-io commented 3 years ago

Codecov Report

Merging #65 (5b7754a) into develop (d29bc44) will increase coverage by 0.02%. The diff coverage is 81.81%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #65      +/-   ##
===========================================
+ Coverage    77.64%   77.66%   +0.02%     
===========================================
  Files           30       31       +1     
  Lines         2259     2270      +11     
===========================================
+ Hits          1754     1763       +9     
- Misses         505      507       +2     
Impacted Files Coverage Δ
aiida_lsmo/calcfunctions/oxidation_state.py 81.81% <81.81%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d29bc44...5b7754a. Read the comment docs.

danieleongari commented 3 years ago

These two are fine: I would ask @kjappelbaum someone with mixed oxidation states to use as an exotic case, which is useful later if we implement the MAGNETIZATION choice in the MultistageWorkChain

kjappelbaum commented 3 years ago

can add Cu(I,II)-HKUST-1 which is also in the manuscript and the app

kjappelbaum commented 3 years ago

KAJZIH_freeONLY.cif.txt

kjappelbaum commented 3 years ago

shall we also store the str(OXIMACHINE_RUNNER) somewhere (to have the oximachine and model version)?

ltalirz commented 3 years ago

shall we also store the str(OXIMACHINE_RUNNER) somewhere (to have the oximachine and model version)?

We probably need both this and the model name/version

ltalirz commented 3 years ago

ah, now I see, it contains it I guess ;-)

ltalirz commented 3 years ago

great!