lsmo-epfl / aiida-lsmo

AiiDA workflows for the LSMO laboratory at EPFL
Other
9 stars 13 forks source link

fix pre-commit #96

Open ltalirz opened 2 years ago

ltalirz commented 2 years ago

Still to fix: _parse_bands uses new interface only available in cp2k develop branch

ltalirz commented 2 years ago

Furthermore, there is one instance of _parse_bands that takes a cp2k version, which is only available in the aiida-cp2k develop branch.

@danieleongari is it safe to use the latest version of the develop branch from aiida-cp2k (in which case I will try to get a new release of aiida-cp2k going) or are there other changes that one needs to watch out for?

codecov-commenter commented 2 years ago

Codecov Report

Merging #96 (65c5f95) into develop (0999cce) will increase coverage by 0.02%. The diff coverage is 3.57%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #96      +/-   ##
===========================================
+ Coverage    70.61%   70.64%   +0.02%     
===========================================
  Files           34       34              
  Lines         2808     2807       -1     
===========================================
  Hits          1983     1983              
+ Misses         825      824       -1     
Impacted Files Coverage Δ
aiida_lsmo/workchains/isotherm_accurate.py 18.62% <3.57%> (+0.07%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0999cce...65c5f95. Read the comment docs.