Open arthur-shaw opened 10 months ago
I am mostly concerned about getting a version of adodown
out that does not crash.
Re confirming the logo is the right dimensions/spec.
Put the logo in the right place in the package file system
My preference for location is src/dev/assets
but that is a weak preference and if you have a strong preference, lets just go with that
including logo in README
Will this be for the web documentation as well? If not, then I think we can just write some documentation for how to do this, but not worrying about our R pacakge to do anything of that.
Let me know what you think!
Wups, it seems I put this issue in the wrong place. I'd meant for adodown to have a command for placing the image in the right place.
On the image location--agreed--let's go with src/dev/assets
.
As an additional consideration, the image should be placed like this:
# pkg_name
<img src='src/dev/assets/logo.png' align="right" height="139" />
Avoid placing it like this (i.e., how it works in pkgdown), since doing so would put the image in the TOC of the Quarto site:
# pkg_name <img src='src/dev/assets/logo.png' align="right" height="139" />
Inspired by
usethis::use_logo()
, this adodown command could do some or all of the following:assets
dir in root of package. See lsms-worldbank/adodownr#6 and https://github.com/lsms-worldbank/labeller/issues/17Here's an example of the Markdown/HTML needed; here's the result of the example.