lspcontainers / lspcontainers.nvim

Neovim plugin for lspcontainers.
Apache License 2.0
313 stars 34 forks source link

fix(gopls): networking mode depending on runtime #76

Closed jgero closed 2 years ago

jgero commented 2 years ago

Fixes the networking part of #68

erikreinert commented 2 years ago

I don't run podman is the slirp4netns a standard value for most setups?

jgero commented 2 years ago

Yes, slirp4netns is the default value for rootless containers and bridge is the default for rootful containers according to the podman man page. Whether rootful or rootless mode is used depends a bit on configuration, but slirp4netns works for rootful containers as well, so using that as default value does work.

erikreinert commented 2 years ago

Got it - okay cool. I recently installed podman and am starting to play to understand how it works. Now that I have a better idea already I think I can make sense of this. I also wanted to note this ticket: https://github.com/lspcontainers/lspcontainers.nvim/issues/84 which should address these types of settings easier.