search

lspcontainers / lspcontainers.nvim

Neovim plugin for lspcontainers.
Apache License 2.0
313 stars 34 forks source link

fix(api): add runtime parameter to images_remove #83

Closed jgero closed 2 years ago

jgero commented 2 years ago

Without this parameter it is not possible to use the API with podman.

Fixes #75

erikreinert commented 2 years ago

This is a good fix - thank you! I do have one other thing to note:

  1. I installed podman finally and I understand it a lot more now (and will probably use it)
  2. With how much we can integrate directly into this - I think we may want to refactor all this docker vs podman logic each time and opt for a require'lspcontainers'.setup({ runtime = "podman" }) which would really allow us to write cleaner code as well.

I opened this ticket https://github.com/lspcontainers/lspcontainers.nvim/issues/84 to solve that problem in the future so we can close this for now.