search

lspestrip / striptease

Strip TEst Analysis for System Evaluation
MIT License
4 stars 3 forks source link

Make error messages clearer when unit-test data taken in Bicocca are not found #103

Open ziotom78 opened 3 months ago

ziotom78 commented 3 months ago

Currently, if the code is not able to download a test from the Unit Test Database, it just produces a “HTTP error 404”. A proper error message should report the number of the test. @lopezcaraballoch

lopezcaraballoch commented 3 months ago

Hola Maurizio,

I continue with the same problem of run python /Users/clopez/software/codes_strip/proganalysis_check_BicoccaTests.py

I run your recommendations: view_procedure_solveProblem_1 and the results of re-running is: view_procedure_solveProblem_2 which provide the same error. In this case, the unit test is 638 (STRIP56, B2). This unit test is available in my ~/.strip/unittests folder.

Sorry to reply late, Carlos

ziotom78 commented 3 months ago

Hi @lopezcaraballoch , you haven't fetched the pull request, so you're still using the old version of the code. (You should have run git fetch origin pull/104/head:no_more_404 before running git checkout.)

However, now that the PR has been merged to master, it's enough to run

git pull

The changes won't make the code work, but the code will print a more informative error message that points to the number of the unit test that was not found in the database.

lopezcaraballoch commented 3 months ago

Hola @ziotom78. Now I updated striptease. In fact, the code work and show an informative error. In my previous comment the problem comes from unit test 638 (STRIP56, B2). Please, How can solve this type of problem? Regards

ziotom78 commented 3 months ago

It looks like test 638 does not exist in the database: https://striptest.fisica.unimi.it/unittests/tests/638/ produces a “Not found” error.

I remember that during our last call we had the very same situation for another test. Francesco told us that it was removed and replaced with newer data once he was able to get additional housekeeping parameters from Bicocca; the newer data was filed under a different number.

You should ask Francesco to know what is the most updated test. (I see there is a DC test done in cryogenic conditions for STRIP56 with number 934: https://striptest.fisica.unimi.it/unittests/tests/934/, but please check with Francesco first!) The number 638 in the Excel file should be replaced with the newer one.