Closed fincardona closed 4 years ago
This choice has a meaning, strictly connected to the hardware architecture. In the electronics we have BIAS boards and Acquisition boards (DAQ). Each is connected to Polarimeters (either for bias or data acquisition).
For this reason Francesco asked to swap groups and subgroups, to reflect the actual hardware logic.
The first input parameter of the
load_hk
method isgroup
which is eitherBIAS
orDAQ
, while the second issubgroup
, that can be either a polarimeter or a board name: https://github.com/lspestrip/striptease/blob/921826363e797db4166a2c7de670c15a4e3eb292/striptease/hdf5files.py#L293 Instead, the first argument ofload_sci
is the polarimeter name: https://github.com/lspestrip/striptease/blob/921826363e797db4166a2c7de670c15a4e3eb292/striptease/hdf5files.py#L332 It might be useful to invert the calling order ofgroup
andsubgroup
inload_hk
to keep it coherent in the two methods.