Add support for GHC 8.10.1

[lukel97]

Continuing the work of @jneira in #305 , rebased

[codygman]

Related to #269

[tfausak]

This doesn't build with GHC 8.4, 8.2, or 8.0. Do you know if it's an easy fix or not?

• 8.4: https://github.com/lspitzner/brittany/pull/324/checks?check_run_id=1402854550
• 8.2: https://github.com/lspitzner/brittany/pull/324/checks?check_run_id=1402854557
• 8.0: https://github.com/lspitzner/brittany/pull/324/checks?check_run_id=1402854564

[jneira]

@tfausak maybe i am not interpreting those builds correctly but they seem fail for ghc-8.10.2 and no for other versions??

EDIT: oh, i've just see you dropped support for those versions in the pr

[jneira]

Afaics all changes in this pr was made under cpp conditions so it should not interfere with older ghc versions (module some error)

[tfausak]

I think some of the CPP changes looked like this:

# if MIN_VERSION_ghc(8, 10, 1)
-- nothing
# else
some existing code
# endif

[jneira]

Yeah, but it should no make fail previous ghc versions but make ghc-8.10.1 fail, no? (sorry if i am wrong i am only gathering at the code without even compiling it)

Can you share the errors that were thrown for earlier versions? are there in the travis failed build for this pr?

[tfausak]

Sorry, my comment wasn't very helpful. Also apparently the links I shared earlier don't work anymore. I probably shouldn't have rebased #324. Here are actually usable links to the build failures:

• 8.4: https://github.com/lspitzner/brittany/runs/1402854550
• 8.2: https://github.com/lspitzner/brittany/runs/1402854557
• 8.0: https://github.com/lspitzner/brittany/runs/1402854564

[tfausak]

I'm closing this in favor of #324, which includes these commits. Please let me know if I've missed something!