search

lspitzner / brittany

haskell source code formatter
GNU Affero General Public License v3.0
690 stars 72 forks source link

Sorted imports 2 #325

Closed expipiplus1 closed 3 years ago

expipiplus1 commented 3 years ago

I've merged the ghc 8.10 branch against the sorted-import branch and added some basic tests (Had to add a blank line function to the test suite)

I'm not sure if I'm being dense, but are there any tests where one enters the initial and expected source files, or is every test a "passthrough" test. i.e. would the identity function pass the testsuite?!

(I've targeted this against the ghc-8.10 branch because it includes those commits too)

The only required checklist items on @lspitzner's PR were:

expipiplus1 commented 3 years ago

If this were to be gated behind a configuration option could this be merged? Or ideally just merged anyway

I'm not sure if I'm being dense, but are there any tests where one enters the initial and expected source files, or is every test a "passthrough" test. i.e. would the identity function pass the testsuite?!

Would be good to get an answer to this too if possible.

tfausak commented 3 years ago

Sorry, I didn't mean to close this. I thought GitHub was supposed to rebase PRs when you delete a branch. Please re-open this against the master branch. Thanks!