search

lspitzner / brittany

haskell source code formatter
GNU Affero General Public License v3.0
690 stars 72 forks source link

Support GHC 9.0 #356

Closed tfausak closed 2 years ago

tfausak commented 2 years ago

This will fix #352, but it's very much a work in progress.

jneira commented 2 years ago

Many thanks for take care, imagining how cumbersome is to have to keep up to date all these packages

tfausak commented 2 years ago

I quickly ran out of easy stuff to fix here. I must say, I'm a bit out of my depth here. Supporting GHC 9 feels possible to me, but maintaining support for earlier versions will be a challenge. I don't normally use CPP, and there are lots of little changes to paper over. Perhaps this should use ghc-lib-parser, but I think that would require changing ghc-exactprint?

tfausak commented 2 years ago

GHC 9.2 was just released: https://discourse.haskell.org/t/ghc-9-2-1-released/3527

tfausak commented 2 years ago

@jneira: Question for you about HLS integration: Does Brittany need to support all the same versions of HLS in order to be bundled with it? I would much rather support a single version of GHC and provide static binaries if that's possible.

jneira commented 2 years ago

I am afraid that is the case, each hls version is shipped for each supported ghc.

tfausak commented 2 years ago

Closing this in favor of #357.