search

lspvic / jupyter_tensorboard

Start Tensorboard in Jupyter Notebook
MIT License
460 stars 81 forks source link

Fix compatibility with TB >= 2.2 #63

Open cliffwoolley opened 4 years ago

cliffwoolley commented 4 years ago

https://github.com/tensorflow/tensorboard/pull/3539 in TensorBoard 2.2 dropped the legacy DB mode, so the unused optional db_* parameters to base_plugin.TBContext() should be dropped, as in https://github.com/tensorflow/tensorboard/commit/628b78fe3efbd98df84410a8841ff96fefa3beac#diff-9f7ffee070d3d2429db0b7178d355ec6L229-L241

cliffwoolley commented 4 years ago

/cc @wchargin

leonardschneider commented 4 years ago

Why is this not merged already? Bumped into this issue.

cliffwoolley commented 3 years ago

I've updated this PR from last year to also include TB 2.3 and TB 2.4 now.

Plus the newer, simplified implementation should allow better future-proofness as well: Instead of pulling out a huge chunks of the entry function to TensorBoard (which by the way no longer exists in TB 2.4) and reimplementing it mostly just to catch the returned object to add to our tensorboard_manager; instead we now just wrap the unmodified TB function from the outside and add to the tensorboard_manager that way. Also we no longer attempt to implement any special multiplexing functionality since TB handles all that on its own and the threading being handled in two places was causing bugs.

rvernaeshv commented 3 years ago

Thanks for this fix... It helps me a lot

wexder commented 3 years ago

@lspvic can we merge this?

cliffwoolley commented 3 years ago

This seems to be working with TB 2.5 as well, fwiw.

billshitg commented 2 years ago

just tried this with TB 2.7 and it worked very well. amazing! thanks for the fix. why has it not been merged already?

videodanchik commented 2 years ago

@lspvic Could you please merge this feature to master and bump up the library version?