search

lsqlabs / ngx-guided-tour

MIT License
96 stars 49 forks source link

Scrolling does not work on modals. #64

Open EliasPh opened 4 years ago

EliasPh commented 4 years ago

Hi, i am implementing a tour through my homepage, which uses modals. (ng-bootstrap - https://ng-bootstrap.github.io/) At one step in my tour i am opening a modal (that works great) but scrolling to a selector at the bottom of that modal does not work. Do you have any idea for a workaround?

Thanks for this very handy tool!

RobertCMusk commented 4 years ago

The current code only scrolls the body to get content into view. It would be a new feature to change the target that is scrolled. Have you tried defining an action in the tourStep definition? You should be able to write your own code to scroll the modal ad add it to the tourStep definition.

joaorodr84 commented 3 years ago

I am going through a similar problem. I just wanted to be able to select which element would be scrolled. I think it would be a very useful feature to add in the upcoming releases.

@RobertCMusk I like your idea to use action, but it seems rather difficult because every calculation is performed relative to the body. I think I would have to write a lot of code. Did you ever do it? Is there a working example somewhere? Thanks