lsretailomni / lsmag-two

LS Ecommerce - Magento, an ecommerce interface for integrating Magento with LS Central.
https://www.lsretail.com/
10 stars 16 forks source link

Merge extension_attributes on addressInformation. When this is not do… #41

Closed ldrooij closed 1 year ago

ldrooij commented 1 year ago

Merge extension_attributes on addressInformation. When this is done extension_attributes from other modules will be overwritten instead of being merged

Description (*)

We ran into an issue where extension_attributes added by other modules on addressInformation during shipping data storage in check-out were overwritten when the payload was modified. Merging the extension_attributes instead of replacing them fixes the issue

Manual testing scenarios (*)

  1. Install module that modifies extension_attributes payload. In the example of module amasty deliverydate manager the selected delivery date and pick-up slot were not stores. (We know the module offers functions for this, but we required additional logic for this).
  2. Complete an order. All the additional data should be saved on the order.

Contribution checklist (*)

lsretailomni commented 1 year ago

@ldrooij thanks for reporting, this is already included in release 2.2.0