search

lsretailomni / lsmag-two

LS Ecommerce - Magento, an ecommerce interface for integrating Magento with LS Central.
https://www.lsretail.com/
10 stars 16 forks source link

Obsolete _isScopePrivate property in blocks #44

Closed bmxmiwe closed 1 year ago

bmxmiwe commented 1 year ago

Preconditions (*)

  1. Magento Version 2.4.3
  2. LS Retail Partner name - Hagar
  3. LS eCommerce - Magento version 1.18 - 2.3.0

The following table shows the private content block(s) that have the _isScopePrivate variables configured making the block not cacheable.

app/code/Ls/Omni/Block/Cart/Coupons.php app/code/Ls/Omni/Block/Cart/Giftcard.php app/code/Ls/Omni/Block/Cart/Loyaltypoints.php

This property is obsolete and will not work properly. Replace _isScopePrivate property by private content instead.

https://developer.adobe.com/commerce/php/development/cache/page/private-content/

umarusaf902 commented 1 year ago

Hi @bmxmiwe, thanks for reporting this. This issue has already been addressed in the latest version i.e. 2.4.0.