Current flipbook functionality truncates the image set by one image

[ericdrosas87]

Describe the bug When sending over a flipbook subject set, the subjects are truncated by one image.

For example if I have a set of 5 images, and I send over a flipbook subject set to the Zooniverse platform then the subject flipbook that gets created only contains 4.

To Reproduce Steps to reproduce the behavior, written in imperative mood:

0. Ensure you do not have an active subject set on the Zooniverse platform
1. Use the variable_stars notebook to send a set of images as a flipbook (make note of the number of images sent)
2. Log in to the Zooniverse platform and navigate to the subject sets page
3. View the subject sent over and confirm it is missing one of the images

Expected behavior A images sent to the Zooniverse platform are all accounted for and make it to the flipbook

Actual behavior A less image is sent over to the Zooniverse platform.

Screenshots N/A

EDC Output N/A

Additional context

Snapshot Github hash from the point in time in which this issue was written up: https://github.com/lsst-epo/citizen-science-notebooks/commit/5b8b849809986def89f6508ae46dabdd154dfd8c

[ericdrosas87]

@jsv1206 I reviewed the variable_stars notebook further and found that the notebook is actually including all of the images, but then this line comes along and truncates the last one:

df_manifest = df_manifest.iloc[:, [4,0,1,2,3,5,6,7]]

Which is in the 2.1 Get Calexp images and Lightcurves cell - was truncating this last image intentional?

[jsv1206]

It is not intentional. I was trying to rearrange columns such that the filename is the first column. There is probably an efficient way to reorganize columns here

[ericdrosas87]

@jsv1206 Should we close out this issue then?

[ericdrosas87]

I'm closing this out due to no activity in the past month