Closed beckynevin closed 11 months ago
@beckynevin I'm off work today, but wanted to respond to this: The returning of a list is intentional to keep the science packages out of the citsci PyPI package. The separation of responsibility is such that the citsci package shouldn't need to be dependent on the science packages. I thought I had modified the Testing
notebook to accommodate for this, but if not I can do so Monday.
This issue was fixed with #72 , the Citizen_Science_Testing
notebook now takes the list and renders a Panda dataframe.
Apologies about not giving a heads up that I made that change and that I forgot to add back that Panda code!
No worries, sounds great and thanks for doing that. I didn't realize it would be such a quick fix or I could've done it myself. I'll close this issue.
Describe the bug Hi @ericdrosas87 , the final cell in citsci notebook now unexpectedly returns a list instead of a dataframe. I think we're probably just missing one line
pd.DataFrame
somewhere incit_sci_pipeline.retrieve_data
. This is true on the main branch and also on the beckynevin/pedgagogy_check_2 To Reproduce Steps to reproduce the behavior, written in imperative mood:Expected behavior Expected df to be a dataframe
Actual behavior df is a list
Screenshots