lsst-epo / citizen-science-notebooks

A collection Jupyter notebooks that can be used to associate Rubin Science Platform data to a Zooniverse citizen science project.
3 stars 1 forks source link

01 notebook setup_butler and run_butler_query are misnomers #88

Open beckynevin opened 5 months ago

beckynevin commented 5 months ago

Describe the bug In some of the first code cells of the 01 notebook, we run:

print('Establishing the connection to the Butler')
config = "dp02"
collection = "2.2i/runs/DP0.2"
service, butler, skymap = utils.setup_butler(config, collection)
print('Connected')

And then:

print('Setting the parameters for making image cutouts')
number_sources = 10000  # change this to 100 for a full subject set test
use_center_coords = "62, -37"
use_radius = "10.0" # increased from 1 to 10
print('Running the Butler query to return objects')
results = utils.run_butler_query(service, number_sources, use_center_coords, use_radius)

The issue is that the setup_butler function is also setting up the tap_query_service, we suggest renaming it setup_query_tools() to reflect that both the butler and tap service are being instantiated/initialized.

Additionally, verify that the run_butler_query() is running just butler and not TAP or rename appropriately.

beckynevin commented 5 months ago

setup_query_tools and run_tap_query() are the new names in utils. I also changed this in 01 and 02 on the variable stars branch

beckynevin commented 5 months ago

The source for why these are TAP queries is the very first introductory DP02 notebook.