lsst-epo / citizen-science-notebooks

A collection Jupyter notebooks that can be used to associate Rubin Science Platform data to a Zooniverse citizen science project.
3 stars 1 forks source link

Utils #9

Closed beckynevin closed 1 year ago

beckynevin commented 1 year ago

This update moves a lot of the imports out of Citizen_Science_Testing.ipynb into utils.py. This is different from the functions in the SDK notebook, which is much more behind the scenes. Instead, utils.py has the plotting tools and such.

bnord commented 1 year ago

@beckynevin Could you briefly walk through (during group meeting) the changes to be made. It's hard to parse the jupyter notebook markdown in the web format.

Is this aimed to be immediately moved to script files?

jsv1206 commented 1 year ago

Could you add these changes i.e. calling utils.py to the latest Citizen_Science_Testing.ipynb and create a pull request?

beckynevin commented 1 year ago

We can talk about this in group meeting today (3/16), I might try to rebase because there have been many changes to main made since I submitted this PR.

beckynevin commented 1 year ago

I'm running into the following conflict error when I try to rebase, I'm wondering if I should remove this branch and create a new one: (lsst-scipipe-5.1.0) [rnevin@sdfrome001 citizen-science-notebooks]$ git rebase main Auto-merging Citizen_Science_Testing.ipynb CONFLICT (content): Merge conflict in Citizen_Science_Testing.ipynb error: could not apply 7b2dca7... Moved a bunch of imports to utils.py hint: Resolve all conflicts manually, mark them as resolved with hint: "git add/rm <conflicted_files>", then run "git rebase --continue". hint: You can instead skip this commit: run "git rebase --skip". hint: To abort and get back to the state before "git rebase", run "git rebase --abort". Could not apply 7b2dca7... Moved a bunch of imports to utils.py