Provide Alternative text for images

blnkt commented 2 years ago

Description

All images must provide alternative text. If images provide additional meaningful information that the surrounding text doesn't already convey, provide an "alt" attribute with meaningful text that describes the image.

Violations

Header/Footer

[ ] Add support in the CMS for providing alt text to the Funding Logos global
[ ] Render provided alt text for funding logos image

Screen Shot 2022-02-03 at 9 53 15 AM

Home

[x] Hompage hero image is decorative in this context, and therefore should have alt="" and be hidden from screen readers using aria-hidden="true" or role="presentation"

"Featured" Images

[ ] Pages' "featured" images are decorative and therefore should have alt="" and be hidden from screen readers using aria-hidden="true" or role="presentation".

Events

[x] Remove unnecessary title on lock svg icon. Hide from screen readers using aria-hidden="true" or role="presentation".

0fdca7993353ab7f566fd83e1035256c6c63be09-1641287766

[x] Event thumbnails are decorative and therefore should have alt="" and be hidden from screen readers using aria-hidden="true" or role="presentation".

42c1fd52548a99fda9b2864b0fc901e8d89235df-1641287243

Contact Links' Icons

[x] Mail and phone icons are decorative and therefore should have alt="" and be hidden from screen readers using aria-hidden="true" or role="presentation". Rubin content editors will edit text of address and phone fields to include indication of what the address and number are.

f3b735f74de3ca0eb673d9319145236b5af9c0ae-1641276122

CIC Estimate

1 point

dananjohnson commented 2 years ago

@blnkt I'm trying to determine what "Featured" images refer to. We have this field on page entries, but it's just used for OpenGraph tags in the HTML <head>. Is there another field I should be looking at?

blnkt commented 2 years ago

@dananjohnson You're right that's not super clear of me. It's been a while now since I wrote/looked at these, but I believe this is in reference to the images used in gridBlocks like, for instance, the Related Items CTA grid. I think it was my guess that those images in the grids were pulling from the featured images. But perhaps I misjudged from whence they are sourced. Either way I think my thought was that images in this tile/thumbnail context were purely decorative and as such could be excluded from screen readers. Thoughts?

dananjohnson commented 2 years ago

@blnkt welcome back! OK that makes sense now, thanks. The commit referenced above (0995cf3) should take care of that.

lsst-epo / rubin-obs-client