search

lsst-sims / legacy_sims_GalSimInterface

code to seamlessly generate simulated images using GalSim based off of simulated catalogs generated by CatSim
5 stars 7 forks source link

Use float_values numpy array for storing the 15 float values in GSCO. #65

Closed rmjarvis closed 6 years ago

rmjarvis commented 6 years ago

An idea floated on todays CI telecon to reduce the memory footprint of the GSCO instances.

danielsf commented 6 years ago

Given that we occasionally end up stuffing new things into the GalSimCelestialObject (for instance, the number of knots in Francois' model), we should probably add a unit test to make sure that the property getters return the same thing that is given to __init__. I can do that.

danielsf commented 6 years ago

Oh. Nevermind. This PR is from a fork. Do you mind adding such a unit test, @rmjarvis ?

rmjarvis commented 6 years ago

I was hoping there would be some Travis run that would check that I didn't break anything with this. But it seems that the unit tests aren't being run automatically.

Is there a standard way for me to install this package and run tests (and then to add a new one and run it) that you could point me to? Or do I need to have the full stack installed and then do some complicated eups esoterica?

danielsf commented 6 years ago

It is, unfortunately, the latter.

If you want to just go ahead and merge, I (as a member of the EUPSophonic community) can write the unit test in a different branch.

rmjarvis commented 6 years ago

Or if you want, you can make a branch and merge this onto that branch instead of master. If you don't want to sully master with possibly error-prone code.

danielsf commented 6 years ago

Okay. I will do that.

danielsf commented 6 years ago

Added the unit test in

https://github.com/lsst/sims_GalSimInterface/pull/67