@rmjarvis Here is the PR that gets the unit tests to pass with your new findAllDetectors scheme.
The unit test that I had to hack is the oldest unit test in this package, written when this was just a CatSim extension, rather than the middleware for ImSim. As such, I feel comfortable just tweaking it to get it to pass (as long as we don't tweak too hard). Most of the functionality is tested in the other unit tests.
Jim and I have talked about removing the galSimCatalogs API completely from this package, in which case that test would go away.
@rmjarvis Here is the PR that gets the unit tests to pass with your new
findAllDetectorsscheme.The unit test that I had to hack is the oldest unit test in this package, written when this was just a CatSim extension, rather than the middleware for ImSim. As such, I feel comfortable just tweaking it to get it to pass (as long as we don't tweak too hard). Most of the functionality is tested in the other unit tests.
Jim and I have talked about removing the
galSimCatalogsAPI completely from this package, in which case that test would go away.