Don't use xValue on profiles with a RandomWalk component

lsst-sims / legacy_sims_GalSimInterface

code to seamlessly generate simulated images using GalSim based off of simulated catalogs generated by CatSim

5 stars 7 forks source link

Don't use xValue on profiles with a RandomWalk component #81

Closed rmjarvis closed 5 years ago

rmjarvis commented 5 years ago

RandomWalk galaxies in GalSim shouldn't be used with real-space convolution. This was inadvertently being done in getGoodPhotImageSize to find a good stamp size for these objects. To avoid this, this PR pulls out the underlying profile and uses that instead of the knotty version, which should produce a good estimate of the stamp size required for the original object.

jchiang87 commented 5 years ago

I ran imSim with this change for the sensor-visit that had the problem with the RandomWalk galaxy: visit 280270, CCD R20_S22. imSim had no problem with that particular galaxy, nor with any of the other ~240k objects drawn on that sensor.

Unless I hear otherwise, I'll merge this at 9am tomorrow.