search

lsst-sims / legacy_sims_GalSimInterface

code to seamlessly generate simulated images using GalSim based off of simulated catalogs generated by CatSim
5 stars 7 forks source link

checkpoint after each postage stamp rendering #86

Closed jchiang87 closed 5 years ago

jchiang87 commented 5 years ago

perhaps the

gsObject.galSimType == 'FitsImage'

should be extended to only force this on sources that are quite bright?

I added 72e54c1 to address this. Ordinarily, I'd make the flux cutoff configurable, but this is meant as a quick fix in code we are going to replace soon, so I hard-wired in the 1e4 cutoff value. Unless I hear otherwise, I'll merge this at 5pm PT today.

cwwalter commented 5 years ago

I added 72e54c1 to address this. Ordinarily, I'd make the flux cutoff configurable, but this is meant as a quick fix in code we are going to replace soon, so I hard-wired in the 1e4 cutoff value. Unless I hear otherwise, I'll merge this at 5pm PT today.

Sounds good. BTW did you notice in your tests if those lower flux fits files guys did in fact render in a reasonable amount of time and it was just the really bright ones that were taking forever?

jchiang87 commented 5 years ago

did you notice in your tests if those lower flux fits files guys did in fact render in a reasonable amount of time and it was just the really bright ones that were taking forever?

I did, and the scaling was essentially linear in flux.