search

lsst-sims / legacy_sims_GalSimInterface

code to seamlessly generate simulated images using GalSim based off of simulated catalogs generated by CatSim
5 stars 7 forks source link

Report WAVEFRONT imports; skip unit tests that used ReturnCamera #94

Closed rhiannonlynne closed 4 years ago

rhiannonlynne commented 4 years ago

I removed the "ReturnCamera" functionality from sims_coordUtils, when it looked simpler to update the sims_coordUtils unit tests which depended on it rather than to update ReturnCamera itself (which no longer worked because afwCameraGeom deprecated makeCameraFromCatalogs .. and makeCameraFromAmpLists seemed close but the segments file didn't seem to match the expected new format, so it wasn't clear what needed to be done and there was a distinct lack of documentation). Anyway - it turns out ReturnCamera is used a lot here, to make a simple one-detector camera. Instead of fixing all of these now, I skipped the unit tests. That'll let the lsst_sims weekly build succeed this week, hopefully. Depending on what the future use of sims_GalSimInterface is (is it being deprecated?), these unit tests should be replaced.

rhiannonlynne commented 4 years ago

deleted branch u/lynnej/update_to_afwcameraGeom