Closed pgris closed 4 years ago
Looking at this and the example notebook:
slicePoint
, so it can be handy to just compute the pixel area in the run
method, then there's no risk of mis-matching the metric and slicer nside.super__init__
. Looks like it's picking up 'z' somehow, but probably supposed to be 'N SLSN'? Thanks for your comments. Let me try to adress them:
about the seam at RA=0: I got the 'season' info when requesting to add the 'season' col in the super.init. I thought that it was the "official" way of estimating the season within MAF metrics. I have added my own way of estimating the seasons in the code. I do not see the seam anymore.
about the extra-galactic m5: the metric is not sensitive to this.
abount nside and sliePoint: done. The (pixel) area is now included in the run() method
units has been added in the super.init
Strongly lensed supernovae metric has been added in sims_maf: