U/lynnej/update literals

[rhiannonlynne]

I'm sorry. This PR is a mess, I fully admit - there are a lot of things jumbled together.

• One is an update to locations where values were being compared to strings -- ' is "expected value"' throws a warning, and should be replaced with ' == "expected value"' (unless expected value is None, in which case it stays as 'is').
• Another is an update to the run scripts - I threw out some, changed the display backend for run_tdc.py, and updated add_fbs_proposals to identify WFD area as the location with more than 750 visits (counting visits longer than 11s).
• There are some changes related to getting the SN metric unit test to run under scons.
• The other changes are related to the TDC metric itself, in seasonsMetrics and descWFDBatch. The commit history is terrible, so will probably squash and merge.

[yoachim]

Unit test fails.

File "/Users/yoachim/git_repos/sims_maf/python/lsst/sims/maf/utils/snNSNUtils.py", line 501, in Load_Atmosphere
    atmosphere.readThroughput(
  File "/Users/yoachim/git_repos/sims_photUtils/python/lsst/sims/photUtils/Bandpass.py", line 214, in readThroughput
    raise IOError('The throughput file %s does not exist' %(filename))
OSError: The throughput file THROUGHPUTS_DIR/atmos.dat does not exist

[rhiannonlynne]

argh, yes. I thought I had fixed it but there is still a weird float around of what the atmosphere directory is defined as. I'll try to sort it out some more.

On Thu, Apr 1, 2021 at 1:58 PM Peter Yoachim @.***> wrote:

Unit test fails.

File "/Users/yoachim/git_repos/sims_maf/python/lsst/sims/maf/utils/snNSNUtils.py", line 501, in Load_Atmosphere atmosphere.readThroughput( File "/Users/yoachim/git_repos/sims_photUtils/python/lsst/sims/photUtils/Bandpass.py", line 214, in readThroughput raise IOError('The throughput file %s does not exist' %(filename)) OSError: The throughput file THROUGHPUTS_DIR/atmos.dat does not exist

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/lsst/sims_maf/pull/210#issuecomment-812168830, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAOFBX4Z2EEDSCBBSLXKRNLTGTM7BANCNFSM42FKWO2Q .

--

Dr R. Lynne Jones Research Scientist @ University of Washington / Dirac Institute / Rubin Observatory she/hers

[rhiannonlynne]

(note that the unit test wasn't actually executing within scons most of the time before - not in the standard build system anyway, since the previous unit test was skipped entirely if sims_maf_contrib wasn't setup).

On Thu, Apr 1, 2021 at 2:39 PM Lynne Jones @.***> wrote:

argh, yes. I thought I had fixed it but there is still a weird float around of what the atmosphere directory is defined as. I'll try to sort it out some more.

On Thu, Apr 1, 2021 at 1:58 PM Peter Yoachim @.***> wrote:

Unit test fails.

File "/Users/yoachim/git_repos/sims_maf/python/lsst/sims/maf/utils/snNSNUtils.py", line 501, in Load_Atmosphere atmosphere.readThroughput( File "/Users/yoachim/git_repos/sims_photUtils/python/lsst/sims/photUtils/Bandpass.py", line 214, in readThroughput raise IOError('The throughput file %s does not exist' %(filename)) OSError: The throughput file THROUGHPUTS_DIR/atmos.dat does not exist

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/lsst/sims_maf/pull/210#issuecomment-812168830, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAOFBX4Z2EEDSCBBSLXKRNLTGTM7BANCNFSM42FKWO2Q .

--

Dr R. Lynne Jones Research Scientist @ University of Washington / Dirac Institute / Rubin Observatory she/hers

--

Dr R. Lynne Jones Research Scientist @ University of Washington / Dirac Institute / Rubin Observatory she/hers

[rhiannonlynne]

Unit test passes. Several other warnings about future failure-modes fixed. Metadata batch updated. TDC metric updated.

[rhiannonlynne]

merged and deleted branch u/lynnej/update_literals