lsst-sssc / ssoforcedphot

MIT License
1 stars 1 forks source link

Ephemeris service #11

Closed szilac closed 3 weeks ago

szilac commented 1 month ago

Change Description

The branch contains the full ephemeris service component. ephemeris_client.py controls the various interfaces. The outputs are uniformized. Each QueryResult returns a dataclass object or a QueryResult list.

Fixed issues: --> closes https://github.com/lsst-sssc/ssoforcedphot/issues/6 --> closes https://github.com/lsst-sssc/ssoforcedphot/issues/7 --> closes https://github.com/lsst-sssc/ssoforcedphot/issues/8 --> closes https://github.com/lsst-sssc/ssoforcedphot/issues/10

New Feature Checklist

Documentation Change Checklist

github-actions[bot] commented 1 month ago
Before [0de6be8c] After [6f5e0aa5] Ratio Benchmark (Parameter)
2.66±1s 1.06±1s ~0.40 benchmarks.time_computation
488 1.27k 2.61 benchmarks.mem_list

Click here to view all benchmarks.

mschwamb commented 1 month ago

I think data directory should go under tests

mschwamb commented 1 month ago

Discussion from the telecon is that ecsv handling is going to be updated

mschwamb commented 4 weeks ago

@akoumjian Are you happy to approve?

mschwamb commented 3 weeks ago

@talister can you review if @akoumjian by your morning Tuesday? It would be good to get this part into the repo