search

lsst-sssc / ssoforcedphot

MIT License
1 stars 1 forks source link

Bug fix PR review checklist. #25

Closed mkelley closed 2 months ago

mkelley commented 2 months ago

Looks like I was just missing a close quote.

codecov-commenter commented 2 months ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Please upload report for BASE (main@b19efc8). Learn more about missing BASE report.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #25 +/- ## ======================================= Coverage ? 77.40% ======================================= Files ? 6 Lines ? 385 Branches ? 0 ======================================= Hits ? 298 Misses ? 87 Partials ? 0 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 2 months ago
Before [b19efc8f] After [3e017a0e] Ratio Benchmark (Parameter)
4.32±0.3s 2.30±1s ~0.53 benchmarks.time_computation
80 3.78k 47.20 benchmarks.mem_list

Click here to view all benchmarks.

mkelley commented 2 months ago

@mschwamb I think this is good to merge. The "When Opened" action failure is due to the old action being run, not my modified action.

mschwamb commented 2 months ago

Looks good to me. Tagged @talister for the second review to get this merged