search

lsst-ts / ts_phosim

High-Level Module to Perturb the PhoSim
GNU General Public License v3.0
0 stars 1 forks source link

Change WEP module names to match WEP v6.0.0 #84

Closed jbkalmbach closed 1 year ago

jbkalmbach commented 1 year ago

Everything's actually been changed in ts_wep already in v6.0 which has been merged. This PR just updates the module names to use the new version of ts_wep. Otherwise you will have errors when trying to import like you are asking about. This is why Jenkins failed last night when building ts_phosim.

In my testing with the new version of ts_wep the only thing that broke is the DonutStamps issue we discussed and that I added into the README with a description of a fix for that.

jbkalmbach commented 1 year ago

Other than that, yeah, when using older notebooks you will have to update the paths when importing. But everything we do can actually be imported without the module name because we have added them to the __init__.py in each module. So instead of:

from lsst.ts.wep.task.generateDonutDirectTask import GenerateDonutDirectDetectTask

you can do

from lsst.ts.wep.task import GenerateDonutDirectDetectTask

and that should work when moving back and forth between versions.