lsst-uk / lasair4

The Great Refactor. Joining lasair-lsst and lasair-lsst-web
Apache License 2.0
0 stars 1 forks source link

ALPHA TEST 04 - The object details page #84

Closed thespacedoctor closed 1 year ago

thespacedoctor commented 1 year ago

This is arguably the most important component of Lasair ... the object details page.

Here are links to 4 objects for your convenience, but please test on any object page you would like.

https://lasair-dev.lsst.ac.uk/objects/ZTF22abycvuz/
https://lasair-dev.lsst.ac.uk/objects/ZTF22aadesap/
https://lasair-dev.lsst.ac.uk/objects/ZTF22aaokuja/
https://lasair-dev.lsst.ac.uk/objects/ZTF22acalgpv/

SUGGESTED CHECKLIST:

mschwamb commented 1 year ago

Too much space is being take up by the header information before you get to the actual data. I would find a way to condense combine/shorten

mschwamb commented 1 year ago
Screenshot 2023-01-20 at 1 49 19 PM

This seems like it could be condensed to half the current space this information occupies on the screen.

mschwamb commented 1 year ago

PS I like the aesthetic very much.

thespacedoctor commented 1 year ago
image

This is what happens on slightly larger screens. I will make this also happen on moderately sized screens and only show the single column view on small screens.

mschwamb commented 1 year ago

That looks better. I still think the TNS and ZTF identifier could could go in one box and then you could have the difference image light curve and external resources as a row below if some of the text was shortened.

smarttgit commented 1 year ago

When we have "Orphan", it would be better to have the standard annotation :

The transient is not obviously associated with any catalogued galaxy nor is it coincident with a known stellar source.

As the current text of "No contexual information is available for this transient" isn't quite accurate. We do have information, but there is no obvious counterpart (also spelling mistake!)

smarttgit commented 1 year ago

The lightcurve plots are only 50 days. Is this only showing what is in the last alert packet and not the full database ? Similarly the export only gives the 15 rows of data, but many more exist. Are we not yet pulling from the cassandra database ? That's essential of course.

thespacedoctor commented 1 year ago

I will fix 'Orphan' annotations.

Re lightcurves, these are the full Cassandra lightcurves. As this is the development server, the database is only ~2 months old, hence the lack of history. The plots are dynamically scaled to show the full lightcurves.

RoyWilliams commented 1 year ago

The old system has a much longer lightcurve for the same object: https://lasair-dev.lsst.ac.uk/objects/ZTF22aadesap/ https://lasair-ztf.lsst.ac.uk/object/ZTF22aadesap/

gpfrancis commented 1 year ago

Is there a reason why the links to other brokers are under the ZTF name rather than external resources?

Is the context map supposed to do anything yet?

smarttgit commented 1 year ago

Would keep the other broker links in that box. I think people will assume "External Resources" are different information sources

smarttgit commented 1 year ago

General comment that the "Info" pop-out is really basic. As in for the total beginner. Nothing wrong with that but we may decide to increase the level of information. Leave as is for now, but worth thinking about.

smarttgit commented 1 year ago

In top left box labelled with object. Would also like to see "Latest mag" and "Latest MJD" Could we do that on same line as the Discovery stats, but right justified ?

Then, when going deeper, could we have summary stat table ? Peak : mag, error, MJD, filter number of good and positive detections

For LSST, we might want one row per filter for Peak : mag, error, MJD, filter, number of good and +ve detections

smarttgit commented 1 year ago

Presume we will have a widget for our Lasair annotations and lightcurve features ?

smarttgit commented 1 year ago

Is it possible for us to link to the avro packet data for each DIASource in the table ? Is that even possible with the cassandra setup ?

smarttgit commented 1 year ago

External resources -could we link to DECals legacy survey sky browser, I've found that quite useful : https://www.legacysurvey.org Seems to be down right now ! Should be able to link to the sky position of the transient.

smarttgit commented 1 year ago

Will want to have a widget for the lightcurve in flux units, which will include the forced. Presume that is straightforward.

RoyWilliams commented 1 year ago

When you say flux , I hope you mean difference flux. We had such trouble with ZTF trying to make apparent magnitude from difference magnitude. Assuming its diff flux: We have this for converting m to f and vice versa, π‘šβˆ’π‘€ = βˆ’2.5log f/𝐹, but there is the mysterious reference mag M and reference flux F. Is that right? What are the reference values?

smarttgit commented 1 year ago

When you say flux , I hope you mean difference flux. We had such trouble with ZTF trying to make apparent magnitude from difference magnitude. Assuming its diff flux:

Yes, difference flux

We have this for converting m to f and vice versa, π‘šβˆ’π‘€ = βˆ’2.5log f/𝐹, but there is the mysterious reference mag M and reference flux F. Is that right? What are the reference values?

Yes, that is right. The difference fluxes will be calibrated (when we get it, in the avro alert packet), in microJanskys, which means f is calibrated microJansky flux, F = 1 and M = 23.9 π‘š = βˆ’2.5log f + M

where m is a an AB mag

thespacedoctor commented 1 year ago

General comment that the "Info" pop-out is really basic. As in for the total beginner. Nothing wrong with that but we may decide to increase the level of information. Leave as is for now, but worth thinking about.

Most of the info tooltips have a 'learn more' link that takes the user directly to the correct section in the docs.

image

Is this what you are thinking about? Or do you want more detailed info given immediately?

thespacedoctor commented 1 year ago

Re vanilla lightcurves. For LSST I am imagining lightcurves to be 'flux-first' like these ATLAS lightcurves:

image

ZTF mags are AB system, right? If so, I can convert these to difference ΞΌJy also.

RoyWilliams commented 1 year ago

AladinLite is not coming up on the object page (see below for javascript console). Surely this is because of last week when we messed about with the javascript loading process .....

Uncaught ReferenceError: d3 is not defined at celestial.min.js:4:1 at celestial.min.js:5:1 (index):1607 Uncaught TypeError: Cannot read properties of undefined (reading 'aladin') at (index):1607:16

thespacedoctor commented 1 year ago

Hi Roy. Is the dev server on the 'develop' branch? These changes should be in the front-page feature branch.

RoyWilliams commented 1 year ago

The code changes I made are on front-page branch and only for the front page. But we also did all that npm and gulp in the lasair/static directory that affects the webserver itself, independent of the code branch.

thespacedoctor commented 1 year ago

Found and fixed the AladinLite issue. The timestamps on vendor.js and other compiled asset files were not being changed on gulp build (a known gulp bug). The django collectstatic command did not see the files as new and collecting them. I have added a 'touch' to the gulp builds to force update the file timestamps.

Note the webserver/static folder is version controlled and so (with this fix) compiled assets are branch dependent (a good thing πŸ˜€ )

smarttgit commented 1 year ago

ZTF mags are AB system, right? If so, I can convert these to difference ΞΌJy also.

Yes, they are in AB

andyxerxes commented 1 year ago

Late to the party as usual. Overall, it's fabulous! Here are various things:

links to other brokers

the cross links to documentation is really good.

light curve: can we mark the discovery date?

context map: I am not getting it!

exporting data works nicely for me. I do wonder whether to advertise an export option in the list curve block.

in useful format? yes- maybe from light curve?

I can view the various image stamps but now I have to learn JS9... an old chestnut, but why are many missing? please explain to punters as well as me.

I tested on phone and tablet. On the phone, it more or less works but is too teeny to be useful. On an iPad, it was much more usable, but still weenier than would be nice. Font size not adjusting? In a quick go, it seemed some things were not working, but I will have another go..

thespacedoctor commented 1 year ago

Thank Andy. All very useful.

light curve: can we mark the discovery date?

What are you imagining? A marker on the x-axis?

context map: I am not getting it!

Roy is experimenting with the front page ... JS has interfered with Aladin. Aladin (context map) is working on the develop branch.

I do wonder whether to advertise an export option in the list curve block.

Good idea.

I can view the various image stamps but now I have to learn JS9... an old chestnut, but why are many missing?

Over to @RoyWilliams or @genghisken on this one. Might be due to being on the development server and not production.

On an iPad, it was much more usable, but still weenier than would be nice. Font size not adjusting?

I need to experiment on a physical iPad/tablet myself ... I'll see if I can get some time on the kids' one!

Tomorrow I will trawl all alpha test responses so far and syphon of individual issues.

thespacedoctor commented 1 year ago

I have now addressed most of the issues/requests from this test. Changes (soon to be deployed) are:

5b55c85b2e41e40886e680cc1c8ea40f

8f2ae77f674c4558ccf5d9c8493e05a9

6b79f8ff52db3d16246f36e13259fc87

5cdf4fe2eace9b4a3560df698512a959

Small Screen Improvements for Lasair

b45dd9bf579d8d0f9cdcc28acbf38d97 960ca0ea386e209240b74b6eb98f8d51

fcfd0e1a26589fd934e356177a02405f

smarttgit commented 1 year ago

Thinking through to LSST (totally understand what you are trying to achieve with the ZTF data here, without access to the real forced phot).

Think 2 different plots are better in two different widgets - one with the unforced and 5-sigma limits (all in mag units) And the other with all the forced data (all in flux)

Are we ok to do that for Lasair-LSST ? Works well in ATLAS and Pan-STARRS

thespacedoctor commented 1 year ago

Yes, and I like the unforced in mags, forced in flux distinction. That will work very nicely. I'm going to create a new issue for this future feature request so it's not lost here.

thespacedoctor commented 1 year ago

@andyxerxes

I do wonder whether to advertise an export option in the list curve block.

image
RoyWilliams commented 1 year ago

The LSST flux unit is the nanoJansky [1]. The formula above has f in microJansky. m = βˆ’2.5log f + 23.9

Therefore if f is in nanoJansky, the correct formula is: m = βˆ’2.5log f + 31.4

[1] On the Choice of LSST Flux Units https://pstn-001.lsst.io/