Closed jrob93 closed 2 months ago
Attention: Patch coverage is 70.83333%
with 7 lines
in your changes are missing coverage. Please review.
Project coverage is 89.35%. Comparing base (
7f0094b
) to head (436cdeb
). Report is 55 commits behind head on main.:exclamation: Current head 436cdeb differs from pull request most recent head 1e71996. Consider uploading reports for the commit 1e71996 to get more accurate results
Files | Patch % | Lines |
---|---|---|
src/adler/utilities/science_utilities.py | 70.83% | 7 Missing :warning: |
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Bare minimum added to test_AdlerCLIArguments.py to get the new sql_fname CLI option to not break the existing unit tests. This option will need inspected and properly unit tested.
And I should probably explain, I added a new CLI option:
-i SQL_FILENAME, --sql_filename SQL_FILENAME Optional input path location of a sql database file containing observations
When this option is provided, it triggers adler to retrieve observations using AdlerPlanetoid.construct_from_SQL
rather than AdlerPlanetoid.construct_from_RSP
.
This makes a start at addressing issue #111
@astronomerritt would be great to get you review on this one, particularly the addition of sql_filename to the CLI. Also the demo version of running the adler command will fail if the data
and plots
directories are not there for the output files to be saved, not sure how to deal with that right now.
Fixes #119 .
Uses the outlier detection functions from PR #113 within the adler CLI to demonstrate the identification of outlying photometry compared to a phase curve model for a given object.
Review Checklist for Source Code Changes