lsst-uk / lsst-adler

Apache License 2.0
1 stars 0 forks source link

order of observations #123

Open jrob93 opened 4 months ago

jrob93 commented 4 months ago

I've been testing AdlerPlanetoid on the RSP and I have noticed that the observations returned by construct_from_SQL and construct_from_RSP are not in time order. Also the two methods return observations in different orders. Not sure what they are ordered by (if anything).

This is probably an RSP/DP0.3 issue, but logging here to avoid any gotchas later on.

astronomerritt commented 4 months ago

Curious and moderately concerning. Thanks for bringing this up.

For consistency at the very least, I should implement something that sorts the retrieved data table on time of observation, before the dataclass attributes are populated. Then we can at least be sure everything is in date order.