So far I have tried to write the PhaseCurve class such that it can handle model parameters with/without units. This is becasue sbpy expects units by default. As long as it doesn't make things tricky I would lean towards trying to use code in adler that is agnostic to variables with/without units. That being said, we will have to strip units from variables at some point anyway, in order to write values to a database.
How do we want to handle parameters that are of type "Quantity". I.e. objects that have a value and unit property https://docs.astropy.org/en/stable/units/
So far I have tried to write the PhaseCurve class such that it can handle model parameters with/without units. This is becasue sbpy expects units by default. As long as it doesn't make things tricky I would lean towards trying to use code in adler that is agnostic to variables with/without units. That being said, we will have to strip units from variables at some point anyway, in order to write values to a database.